You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Darrick J. Wong 0ea4ed8e94 KVM: Prevent kvm_init from corrupting debugfs structures ... I'm seeing an oops condition when kvm-intel and kvm-amd are modprobe'd during boot (say on an Intel system) and then rmmod'd: # modprobe kvm-intel kvm_init() kvm_init_debug() kvm_arch_init() <-- stores debugfs dentries internally (success, etc) # modprobe kvm-amd kvm_init() kvm_init_debug() <-- second initialization clobbers kvm's internal pointers to dentries kvm_arch_init() kvm_exit_debug() <-- and frees them # rmmod kvm-intel kvm_exit() kvm_exit_debug() <-- double free of debugfs files! *BOOM* If execution gets to the end of kvm_init(), then the calling module has been established as the kvm provider. Move the debugfs initialization to the end of the function, and remove the now-unnecessary call to kvm_exit_debug() from the error path. That way we avoid trampling on the debugfs entries and freeing them twice. Cc: stable@kernel.org Signed-off-by: Darrick J. Wong <djwong@us.ibm.com> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>		15 years ago
..
Kconfig	…
coalesced_mmio.c	KVM: make io_bus interface more robust	16 years ago
coalesced_mmio.h	…
eventfd.c	KVM: correct error-handling code	16 years ago
ioapic.c	KVM: Fix coalesced interrupt reporting in IOAPIC	16 years ago
ioapic.h	…
iodev.h	…
iommu.c	…
irq_comm.c	…
kvm_main.c	KVM: Prevent kvm_init from corrupting debugfs structures	15 years ago