You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Sougata Santra 89ac9b4d3d hfsplus: fix longname handling ... Longname is not correctly handled by hfsplus driver. If an attempt to create a longname(>255) file/directory is made, it succeeds by creating a file/directory with HFSPLUS_MAX_STRLEN and incorrect catalog key. Thus leaving the volume in an inconsistent state. This patch fixes this issue. Although lookup is always called first to create a negative entry, so just doing a check in lookup would probably fix this issue. I choose to propagate error to other iops as well. Please NOTE: I have factored out hfsplus_cat_build_key_with_cnid from hfsplus_cat_build_key, to avoid unncessary branching. Thanks a lot. TEST: ------ dir="TEST_DIR" cdir=`pwd` name255="_123456789_123456789_123456789_123456789_123456789_123456789\ _123456789_123456789_123456789_123456789_123456789_123456789_123456789\ _123456789_123456789_123456789_123456789_123456789_123456789_123456789\ _123456789_123456789_123456789_123456789_123456789_1234" name256="${name255}5" mkdir $dir cd $dir touch $name255 rm -f $name255 touch $name256 ls -la cd $cdir rm -rf $dir RESULT: ------- [sougata@ultrabook tmp]$ cdir=`pwd` [sougata@ultrabook tmp]$ name255="_123456789_123456789_123456789_123456789_123456789_123456789\ > _123456789_123456789_123456789_123456789_123456789_123456789_123456789\ > _123456789_123456789_123456789_123456789_123456789_123456789_123456789\ > _123456789_123456789_123456789_123456789_123456789_1234" [sougata@ultrabook tmp]$ name256="${name255}5" [sougata@ultrabook tmp]$ [sougata@ultrabook tmp]$ mkdir $dir [sougata@ultrabook tmp]$ cd $dir [sougata@ultrabook TEST_DIR]$ touch $name255 [sougata@ultrabook TEST_DIR]$ rm -f $name255 [sougata@ultrabook TEST_DIR]$ touch $name256 [sougata@ultrabook TEST_DIR]$ ls -la ls: cannot access _123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_1234: No such file or directory total 0 drwxrwxr-x 1 sougata sougata 3 Feb 20 19:56 . drwxrwxrwx 1 root root 6 Feb 20 19:56 .. -????????? ? ? ? ? ? _123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_1234 [sougata@ultrabook TEST_DIR]$ cd $cdir [sougata@ultrabook tmp]$ rm -rf $dir rm: cannot remove `TEST_DIR': Directory not empty -ENAMETOOLONG returned from hfsplus_asc2uni was not propaged to iops. This allowed hfsplus to create files/directories with HFSPLUS_MAX_STRLEN and incorrect keys, leaving the FS in an inconsistent state. This patch fixes this issue. Signed-off-by: Sougata Santra <sougata@tuxera.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Cc: Vyacheslav Dubeyko <slava@dubeyko.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		10 years ago
..
Kconfig	…
Makefile	…
acl.h	hfsplus: use generic posix ACL infrastructure	11 years ago
attributes.c	hfsplus: remove unused routine hfsplus_attr_build_key_uni	11 years ago
bfind.c	…
bitmap.c	…
bnode.c	hfsplus: fix "unused node is not erased" error	11 years ago
brec.c	…
btree.c	hfsplus: fix "unused node is not erased" error	11 years ago
catalog.c	hfsplus: fix longname handling	10 years ago
dir.c	hfsplus: fix longname handling	10 years ago
extents.c	fs/hfsplus: fix pr_foo() and hfs_dbg formats	11 years ago
hfsplus_fs.h	hfsplus: fix longname handling	10 years ago
hfsplus_raw.h	hfsplus: fix "unused node is not erased" error	11 years ago
inode.c	write_iter variants of {__,}generic_file_aio_write()	11 years ago
ioctl.c	…
options.c	fs/hfsplus/options.c: replace seq_printf by seq_puts	11 years ago
part_tbl.c	…
posix_acl.c	hfsplus: use generic posix ACL infrastructure	11 years ago
super.c	hfsplus: fix longname handling	10 years ago
tables.c	…
unicode.c	…
wrapper.c	fs/hfsplus/wrapper.c: replace shift loop by ilog2	11 years ago
xattr.c	hfsplus: fix compiler warning on PowerPC	11 years ago
xattr.h	hfsplus: use xattr handlers for removexattr	11 years ago
xattr_security.c	hfsplus: correct usage of HFSPLUS_ATTR_MAX_STRLEN for non-English attributes	11 years ago
xattr_trusted.c	hfsplus: correct usage of HFSPLUS_ATTR_MAX_STRLEN for non-English attributes	11 years ago
xattr_user.c	hfsplus: correct usage of HFSPLUS_ATTR_MAX_STRLEN for non-English attributes	11 years ago