You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Mika Westerberg f1c089e319 net: ep93xx_eth: fix DMA API violations ... Russell King said: > > So, to summarize what its doing: > > 1. It allocates buffers for rx and tx. > 2. It maps them with dma_map_single(). > This transfers ownership of the buffer to the DMA device. > 3. In ep93xx_xmit, > 3a. It copies the data into the buffer with skb_copy_and_csum_dev() > This violates the DMA buffer ownership rules - the CPU should > not be writing to this buffer while it is (in principle) owned > by the DMA device. > 3b. It then calls dma_sync_single_for_cpu() for the buffer. > This transfers ownership of the buffer to the CPU, which surely > is the wrong direction. > 4. In ep93xx_rx, > 4a. It calls dma_sync_single_for_cpu() for the buffer. > This at least transfers the DMA buffer ownership to the CPU > before the CPU reads the buffer > 4b. It then uses skb_copy_to_linear_data() to copy the data out. > At no point does it transfer ownership back to the DMA device. > 5. When the driver is removed, it dma_unmap_single()'s the buffer. > This transfers ownership of the buffer to the CPU. > 6. It frees the buffer. > > While it may work on ep93xx, it's not respecting the DMA API rules, > and with DMA debugging enabled it will probably encounter quite a few > warnings. This patch fixes these violations. Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com> Tested-by: Petr Stetiar <ynezz@true.cz> Signed-off-by: David S. Miller <davem@davemloft.net>		14 years ago
..
Kconfig	ARM: 5865/1: nuc900 ethernet driver needs mii	15 years ago
Makefile	…
am79c961a.c	NET: am79c961: fix assembler warnings	14 years ago
am79c961a.h	am79c961a: Use net_device_stats from struct net_device	15 years ago
at91_ether.c	net: trans_start cleanups	15 years ago
at91_ether.h	…
ep93xx_eth.c	net: ep93xx_eth: fix DMA API violations	14 years ago
ether1.c	ether1: Use net_device_stats from struct net_device	15 years ago
ether1.h	ether1: Use net_device_stats from struct net_device	15 years ago
ether3.c	ether3: Use net_device_stats from struct net_device	15 years ago
ether3.h	ether3: Use net_device_stats from struct net_device	15 years ago
etherh.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6	14 years ago
ixp4xx_eth.c	ptp: Added a clock driver for the IXP46x.	14 years ago
ks8695net.c	ethtool: cosmetic: Use ethtool ethtool_cmd_speed API	14 years ago
ks8695net.h	…
w90p910_ether.c	drivers/net: normalize TX_TIMEOUT	14 years ago