You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Dave Young 537d59af73 bluetooth: rfcomm_dev_state_change deadlock fix ... There's logic in __rfcomm_dlc_close: rfcomm_dlc_lock(d); d->state = BT_CLOSED; d->state_changed(d, err); rfcomm_dlc_unlock(d); In rfcomm_dev_state_change, it's possible that rfcomm_dev_put try to take the dlc lock, then we will deadlock. Here fixed it by unlock dlc before rfcomm_dev_get in rfcomm_dev_state_change. why not unlock just before rfcomm_dev_put? it's because there's another problem. rfcomm_dev_get/rfcomm_dev_del will take rfcomm_dev_lock, but in rfcomm_dev_add the lock order is : rfcomm_dev_lock --> dlc lock so I unlock dlc before the taken of rfcomm_dev_lock. Actually it's a regression caused by commit 1905f6c736 ("bluetooth : __rfcomm_dlc_close lock fix"), the dlc state_change could be two callbacks : rfcomm_sk_state_change and rfcomm_dev_state_change. I missed the rfcomm_sk_state_change that time. Thanks Arjan van de Ven <arjan@linux.intel.com> for the effort in commit 4c8411f8c1 ("bluetooth: fix locking bug in the rfcomm socket cleanup handling") but he missed the rfcomm_dev_state_change lock issue. Signed-off-by: Dave Young <hidave.darkstar@gmail.com> Acked-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: David S. Miller <davem@davemloft.net>		17 years ago
..
bnep	bluetooth: use get/put_unaligned_* helpers	17 years ago
cmtp	[BLUETOOTH]: Use sockfd_put()	17 years ago
hidp	bluetooth: uninlining	17 years ago
rfcomm	bluetooth: rfcomm_dev_state_change deadlock fix	17 years ago
Kconfig	[S390] Kconfig: unwanted menus for s390.	18 years ago
Makefile	…
af_bluetooth.c	bluetooth : use lockdep sub-classes for diffrent bluetooth protocol	17 years ago
hci_conn.c	bluetooth: put hci dev after del conn	17 years ago
hci_core.c	bluetooth: hci_core: defer hci_unregister_sysfs()	17 years ago
hci_event.c	bluetooth: use get/put_unaligned_* helpers	17 years ago
hci_sock.c	bluetooth: use get/put_unaligned_* helpers	17 years ago
hci_sysfs.c	bluetooth: do not move child device other than rfcomm	17 years ago
l2cap.c	bluetooth: use get/put_unaligned_* helpers	17 years ago
lib.c	[NET] BLUETOOTH: Fix whitespace errors.	18 years ago
sco.c	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6	17 years ago