Remove usage of the request substate machine for ssp task management requests identified by: ireq->ttype == tmf_task && dev->dev_type == SAS_END_DEV; The only routine that checks the base 'started' state is scic_sds_io_request_tc_completion which calls the substate machine handler if we are not in the 'started' state or we are 'started' and no substate machine is defined. This routine requires no conversion because we have transitioned out of 'started' and the substate routine will be called naturally as a result. There are also no side effects of this conversion on exiting the 'started', state because it only stops the substate machine, which is no longer relevant for this transaction type. Reported-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Dan Williams <dan.j.williams@intel.com>tirimbino
Dan Williams
14 years ago
parent
e2f8db509f
commit
f139303d17
@ -1,240 +0,0 @@ |
||||
/*
|
||||
* This file is provided under a dual BSD/GPLv2 license. When using or |
||||
* redistributing this file, you may do so under either license. |
||||
* |
||||
* GPL LICENSE SUMMARY |
||||
* |
||||
* Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved. |
||||
* |
||||
* This program is free software; you can redistribute it and/or modify |
||||
* it under the terms of version 2 of the GNU General Public License as |
||||
* published by the Free Software Foundation. |
||||
* |
||||
* This program is distributed in the hope that it will be useful, but |
||||
* WITHOUT ANY WARRANTY; without even the implied warranty of |
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU |
||||
* General Public License for more details. |
||||
* |
||||
* You should have received a copy of the GNU General Public License |
||||
* along with this program; if not, write to the Free Software |
||||
* Foundation, Inc., 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA. |
||||
* The full GNU General Public License is included in this distribution |
||||
* in the file called LICENSE.GPL. |
||||
* |
||||
* BSD LICENSE |
||||
* |
||||
* Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved. |
||||
* All rights reserved. |
||||
* |
||||
* Redistribution and use in source and binary forms, with or without |
||||
* modification, are permitted provided that the following conditions |
||||
* are met: |
||||
* |
||||
* * Redistributions of source code must retain the above copyright |
||||
* notice, this list of conditions and the following disclaimer. |
||||
* * Redistributions in binary form must reproduce the above copyright |
||||
* notice, this list of conditions and the following disclaimer in |
||||
* the documentation and/or other materials provided with the |
||||
* distribution. |
||||
* * Neither the name of Intel Corporation nor the names of its |
||||
* contributors may be used to endorse or promote products derived |
||||
* from this software without specific prior written permission. |
||||
* |
||||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS |
||||
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT |
||||
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR |
||||
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT |
||||
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, |
||||
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT |
||||
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, |
||||
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY |
||||
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT |
||||
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE |
||||
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
||||
*/ |
||||
|
||||
#include "host.h" |
||||
#include "request.h" |
||||
#include "state_machine.h" |
||||
#include "scu_task_context.h" |
||||
#include "scu_completion_codes.h" |
||||
|
||||
/**
|
||||
* This method processes the completions transport layer (TL) status to |
||||
* determine if the RAW task management frame was sent successfully. If the |
||||
* raw frame was sent successfully, then the state for the task request |
||||
* transitions to waiting for a response frame. |
||||
* @sci_req: This parameter specifies the request for which the TC |
||||
* completion was received. |
||||
* @completion_code: This parameter indicates the completion status information |
||||
* for the TC. |
||||
* |
||||
* Indicate if the tc completion handler was successful. SCI_SUCCESS currently |
||||
* this method always returns success. |
||||
*/ |
||||
static enum sci_status scic_sds_ssp_task_request_await_tc_completion_tc_completion_handler( |
||||
struct scic_sds_request *sci_req, |
||||
u32 completion_code) |
||||
{ |
||||
switch (SCU_GET_COMPLETION_TL_STATUS(completion_code)) { |
||||
case SCU_MAKE_COMPLETION_STATUS(SCU_TASK_DONE_GOOD): |
||||
scic_sds_request_set_status( |
||||
sci_req, SCU_TASK_DONE_GOOD, SCI_SUCCESS |
||||
); |
||||
|
||||
sci_base_state_machine_change_state( |
||||
&sci_req->started_substate_machine, |
||||
SCIC_SDS_IO_REQUEST_STARTED_TASK_MGMT_SUBSTATE_AWAIT_TC_RESPONSE |
||||
); |
||||
break; |
||||
|
||||
case SCU_MAKE_COMPLETION_STATUS(SCU_TASK_DONE_ACK_NAK_TO): |
||||
/*
|
||||
* Currently, the decision is to simply allow the task request to |
||||
* timeout if the task IU wasn't received successfully. |
||||
* There is a potential for receiving multiple task responses if we |
||||
* decide to send the task IU again. */ |
||||
dev_warn(scic_to_dev(sci_req->owning_controller), |
||||
"%s: TaskRequest:0x%p CompletionCode:%x - " |
||||
"ACK/NAK timeout\n", |
||||
__func__, |
||||
sci_req, |
||||
completion_code); |
||||
|
||||
sci_base_state_machine_change_state( |
||||
&sci_req->started_substate_machine, |
||||
SCIC_SDS_IO_REQUEST_STARTED_TASK_MGMT_SUBSTATE_AWAIT_TC_RESPONSE |
||||
); |
||||
break; |
||||
|
||||
default: |
||||
/*
|
||||
* All other completion status cause the IO to be complete. If a NAK |
||||
* was received, then it is up to the user to retry the request. */ |
||||
scic_sds_request_set_status( |
||||
sci_req, |
||||
SCU_NORMALIZE_COMPLETION_STATUS(completion_code), |
||||
SCI_FAILURE_CONTROLLER_SPECIFIC_IO_ERR |
||||
); |
||||
|
||||
sci_base_state_machine_change_state(&sci_req->state_machine, |
||||
SCI_BASE_REQUEST_STATE_COMPLETED); |
||||
break; |
||||
} |
||||
|
||||
return SCI_SUCCESS; |
||||
} |
||||
|
||||
/**
|
||||
* This method is responsible for processing a terminate/abort request for this |
||||
* TC while the request is waiting for the task management response |
||||
* unsolicited frame. |
||||
* @sci_req: This parameter specifies the request for which the |
||||
* termination was requested. |
||||
* |
||||
* This method returns an indication as to whether the abort request was |
||||
* successfully handled. need to update to ensure the received UF doesn't cause |
||||
* damage to subsequent requests (i.e. put the extended tag in a holding |
||||
* pattern for this particular device). |
||||
*/ |
||||
static enum sci_status scic_sds_ssp_task_request_await_tc_response_abort_handler( |
||||
struct scic_sds_request *request) |
||||
{ |
||||
sci_base_state_machine_change_state(&request->state_machine, |
||||
SCI_BASE_REQUEST_STATE_ABORTING); |
||||
sci_base_state_machine_change_state(&request->state_machine, |
||||
SCI_BASE_REQUEST_STATE_COMPLETED); |
||||
return SCI_SUCCESS; |
||||
} |
||||
|
||||
/**
|
||||
* This method processes an unsolicited frame while the task mgmt request is |
||||
* waiting for a response frame. It will copy the response data, release |
||||
* the unsolicited frame, and transition the request to the |
||||
* SCI_BASE_REQUEST_STATE_COMPLETED state. |
||||
* @sci_req: This parameter specifies the request for which the |
||||
* unsolicited frame was received. |
||||
* @frame_index: This parameter indicates the unsolicited frame index that |
||||
* should contain the response. |
||||
* |
||||
* This method returns an indication of whether the TC response frame was |
||||
* handled successfully or not. SCI_SUCCESS Currently this value is always |
||||
* returned and indicates successful processing of the TC response. Should |
||||
* probably update to check frame type and make sure it is a response frame. |
||||
*/ |
||||
static enum sci_status scic_sds_ssp_task_request_await_tc_response_frame_handler( |
||||
struct scic_sds_request *request, |
||||
u32 frame_index) |
||||
{ |
||||
scic_sds_io_request_copy_response(request); |
||||
|
||||
sci_base_state_machine_change_state(&request->state_machine, |
||||
SCI_BASE_REQUEST_STATE_COMPLETED); |
||||
scic_sds_controller_release_frame(request->owning_controller, |
||||
frame_index); |
||||
return SCI_SUCCESS; |
||||
} |
||||
|
||||
static const struct scic_sds_io_request_state_handler scic_sds_ssp_task_request_started_substate_handler_table[] = { |
||||
[SCIC_SDS_IO_REQUEST_STARTED_TASK_MGMT_SUBSTATE_AWAIT_TC_COMPLETION] = { |
||||
.abort_handler = scic_sds_request_started_state_abort_handler, |
||||
.tc_completion_handler = scic_sds_ssp_task_request_await_tc_completion_tc_completion_handler, |
||||
}, |
||||
[SCIC_SDS_IO_REQUEST_STARTED_TASK_MGMT_SUBSTATE_AWAIT_TC_RESPONSE] = { |
||||
.abort_handler = scic_sds_ssp_task_request_await_tc_response_abort_handler, |
||||
.frame_handler = scic_sds_ssp_task_request_await_tc_response_frame_handler, |
||||
} |
||||
}; |
||||
|
||||
/**
|
||||
* This method performs the actions required when entering the |
||||
* SCIC_SDS_IO_REQUEST_STARTED_TASK_MGMT_SUBSTATE_AWAIT_TC_COMPLETION |
||||
* sub-state. This includes setting the IO request state handlers for this |
||||
* sub-state. |
||||
* @object: This parameter specifies the request object for which the sub-state |
||||
* change is occurring. |
||||
* |
||||
* none. |
||||
*/ |
||||
static void scic_sds_io_request_started_task_mgmt_await_tc_completion_substate_enter( |
||||
void *object) |
||||
{ |
||||
struct scic_sds_request *sci_req = object; |
||||
|
||||
SET_STATE_HANDLER( |
||||
sci_req, |
||||
scic_sds_ssp_task_request_started_substate_handler_table, |
||||
SCIC_SDS_IO_REQUEST_STARTED_TASK_MGMT_SUBSTATE_AWAIT_TC_COMPLETION |
||||
); |
||||
} |
||||
|
||||
/**
|
||||
* This method performs the actions required when entering the |
||||
* SCIC_SDS_IO_REQUEST_STARTED_SUBSTATE_AWAIT_TC_RESPONSE sub-state. This |
||||
* includes setting the IO request state handlers for this sub-state. |
||||
* @object: This parameter specifies the request object for which the sub-state |
||||
* change is occurring. |
||||
* |
||||
* none. |
||||
*/ |
||||
static void scic_sds_io_request_started_task_mgmt_await_task_response_substate_enter( |
||||
void *object) |
||||
{ |
||||
struct scic_sds_request *sci_req = object; |
||||
|
||||
SET_STATE_HANDLER( |
||||
sci_req, |
||||
scic_sds_ssp_task_request_started_substate_handler_table, |
||||
SCIC_SDS_IO_REQUEST_STARTED_TASK_MGMT_SUBSTATE_AWAIT_TC_RESPONSE |
||||
); |
||||
} |
||||
|
||||
const struct sci_base_state scic_sds_io_request_started_task_mgmt_substate_table[] = { |
||||
[SCIC_SDS_IO_REQUEST_STARTED_TASK_MGMT_SUBSTATE_AWAIT_TC_COMPLETION] = { |
||||
.enter_state = scic_sds_io_request_started_task_mgmt_await_tc_completion_substate_enter, |
||||
}, |
||||
[SCIC_SDS_IO_REQUEST_STARTED_TASK_MGMT_SUBSTATE_AWAIT_TC_RESPONSE] = { |
||||
.enter_state = scic_sds_io_request_started_task_mgmt_await_task_response_substate_enter, |
||||
}, |
||||
}; |
||||
|
||||
Loading…
Reference in new issue