diff --git a/vibrator/Vibrator.cpp b/vibrator/Vibrator.cpp index 7c06f23..5d58525 100644 --- a/vibrator/Vibrator.cpp +++ b/vibrator/Vibrator.cpp @@ -86,7 +86,7 @@ ndk::ScopedAStatus Vibrator::on(int32_t timeoutMs, const std::shared_ptr& callback, int32_t* _aidl_return) { ndk::ScopedAStatus status; - uint8_t amplitude; + float amplitude; uint32_t ms; amplitude = strengthToAmplitude(strength, &status); @@ -129,16 +129,14 @@ ndk::ScopedAStatus Vibrator::getSupportedEffects(std::vector* _aidl_retu ndk::ScopedAStatus Vibrator::setAmplitude(float amplitude) { uint32_t intensity; - if (amplitude == 0) { - return ndk::ScopedAStatus::fromExceptionCode(EX_ILLEGAL_ARGUMENT); + if (amplitude <= 0.0f || amplitude > 1.0f) { + return ndk::ScopedAStatus(AStatus_fromExceptionCode(EX_ILLEGAL_ARGUMENT)); } - LOG(DEBUG) << "Setting amplitude: " << (uint32_t)amplitude; + LOG(DEBUG) << "Setting amplitude: " << amplitude; + + intensity = amplitude * INTENSITY_MAX; - intensity = std::lround((amplitude - 1) * INTENSITY_MAX / 254.0); - if (intensity > INTENSITY_MAX) { - intensity = INTENSITY_MAX; - } LOG(DEBUG) << "Setting intensity: " << intensity; return writeNode(VIBRATOR_TIMEOUT_PATH, intensity); @@ -240,16 +238,16 @@ ndk::ScopedAStatus Vibrator::activate(uint32_t timeoutMs) { return writeNode(VIBRATOR_TIMEOUT_PATH, timeoutMs); } -uint8_t Vibrator::strengthToAmplitude(EffectStrength strength, ndk::ScopedAStatus* status) { +float Vibrator::strengthToAmplitude(EffectStrength strength, ndk::ScopedAStatus* status) { *status = ndk::ScopedAStatus::ok(); switch (strength) { case EffectStrength::LIGHT: - return 64; + return AMPLITUDE_LIGHT; case EffectStrength::MEDIUM: - return 128; + return AMPLITUDE_MEDIUM; case EffectStrength::STRONG: - return 255; + return AMPLITUDE_STRONG; } *status = ndk::ScopedAStatus::fromExceptionCode(EX_UNSUPPORTED_OPERATION); diff --git a/vibrator/Vibrator.h b/vibrator/Vibrator.h index a9e4ef5..d5a4bb2 100644 --- a/vibrator/Vibrator.h +++ b/vibrator/Vibrator.h @@ -12,6 +12,10 @@ #define INTENSITY_MAX 10000 #define INTENSITY_DEFAULT INTENSITY_MAX +#define AMPLITUDE_LIGHT 0.25 +#define AMPLITUDE_MEDIUM 0.5 +#define AMPLITUDE_STRONG 1 + #define VIBRATOR_TIMEOUT_PATH "/sys/class/timed_output/vibrator/enable" #define VIBRATOR_INTENSITY_PATH "/sys/class/timed_output/vibrator/intensity" @@ -59,7 +63,7 @@ public: private: ndk::ScopedAStatus activate(uint32_t ms); static uint32_t effectToMs(Effect effect, ndk::ScopedAStatus* status); - static uint8_t strengthToAmplitude(EffectStrength strength, ndk::ScopedAStatus* status); + static float strengthToAmplitude(EffectStrength strength, ndk::ScopedAStatus* status); bool mEnabled{false}; bool mExternalControl{false};